Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use path parameter defaults from routes #44

Merged
merged 1 commit into from
Dec 8, 2023
Merged

feat: Use path parameter defaults from routes #44

merged 1 commit into from
Dec 8, 2023

Conversation

provokateurin
Copy link
Member

Closes #34

@nickvergessen
Copy link
Member

Do we have a sample app?

@provokateurin
Copy link
Member Author

theming in server has one route

nickvergessen
nickvergessen approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in theming

@nickvergessen nickvergessen merged commit f4bda54 into main Dec 8, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the feat/path-parameter-defaults branch December 8, 2023 08:42
@nickvergessen nickvergessen mentioned this pull request Dec 8, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support defaults values in routes.php for path parameters
2 participants
@provokateurin @nickvergessen