fix(tests): Adjust some copy-paste description and add openapi-full.json

Signed-off-by: Joas Schilling <[email protected]>
nextcloud · Jan 12, 2024 · 9abc4c1 · 9abc4c1
1 parent 5c2ff04
commit 9abc4c1
Show file tree

Hide file tree

Showing 7 changed files with 1,832 additions and 10 deletions.
diff --git a/tests/lib/Controller/AdminSettingsController.php b/tests/lib/Controller/AdminSettingsController.php
@@ -68,7 +68,7 @@ public function movedToSettingsTag(): DataResponse {
 	}
 
 	/**
-	 * Route in default scope with tags
+	 * Route in default scope with tags but without named parameters on the attribute
 	 *
 	 * @return DataResponse<Http::STATUS_OK, array<empty>, array{}>
 	 *

diff --git a/tests/lib/Controller/FederationController.php b/tests/lib/Controller/FederationController.php
@@ -43,7 +43,7 @@ class FederationController extends OCSController {
 	/**
 	 * @NoAdminRequired
 	 *
-	 * Route is ignored because of scope on the controller
+	 * Route is in federation scope as per controller scope
 	 *
 	 * @return DataResponse<Http::STATUS_OK, array<empty>, array{}>
 	 *
@@ -56,7 +56,7 @@ public function federationByController(): DataResponse {
 	/**
 	 * @NoAdminRequired
 	 *
-	 * Route is only in the default scope
+	 * Route is only in the default scope (moved from federation)
 	 *
 	 * @return DataResponse<Http::STATUS_OK, array<empty>, array{}>
 	 *

diff --git a/tests/lib/Controller/SettingsController.php b/tests/lib/Controller/SettingsController.php
@@ -124,7 +124,7 @@ public function defaultAndAdminScope(): DataResponse {
 	/**
 	 * @NoAdminRequired
 	 *
-	 * Route is ignored because of scope on the controller
+	 * Route is referencing nested schemas
 	 *
 	 * @return DataResponse<Http::STATUS_OK, list<NotificationsNotification>, array{}>
 	 *
@@ -137,7 +137,7 @@ public function nestedSchemas(): DataResponse {
 	/**
 	 * @NoAdminRequired
 	 *
-	 * Route is ignored because of scope on the controller
+	 * Route is referencing a schema which is a list of schemas
 	 *
 	 * @return DataResponse<Http::STATUS_OK, NotificationsCollection, array{}>
 	 *

diff --git a/tests/openapi-administration.json b/tests/openapi-administration.json
@@ -228,7 +228,7 @@
         "/ocs/v2.php/apps/notifications/api/{apiVersion}/moved-with-unnamed-tag": {
             "post": {
                 "operationId": "settings-admin-settings-moved-to-settings-tag-unnamed",
-                "summary": "Route in default scope with tags",
+                "summary": "Route in default scope with tags but without named parameters on the attribute",
                 "description": "This endpoint requires admin access",
                 "tags": [
                     "settings",

diff --git a/tests/openapi-federation.json b/tests/openapi-federation.json
@@ -50,7 +50,7 @@
         "/ocs/v2.php/apps/notifications/api/{apiVersion}/controller-scope": {
             "post": {
                 "operationId": "federation-federation-by-controller",
-                "summary": "Route is ignored because of scope on the controller",
+                "summary": "Route is in federation scope as per controller scope",
                 "tags": [
                     "federation"
                 ],
-Original file line number
+Diff line change
@@ Expand Up / @@ -68,7 +68,7 @@ public function movedToSettingsTag(): DataResponse { @@
     	}
     	/**
-    	 * Route in default scope with tags
+    	 * Route in default scope with tags but without named parameters on the attribute
     	 *
     	 * @return DataResponse<Http::STATUS_OK, array<empty>, array{}>
     	 *
@@ Expand Down @@