Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GS): consolidate and extend CSP management #559

Merged
merged 1 commit into from
Jan 27, 2025
Merged

fix(GS): consolidate and extend CSP management #559

merged 1 commit into from
Jan 27, 2025

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented May 16, 2024

Summary

based on nextcloud/richdocuments#3237

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@blizzz blizzz changed the title fix(GS): consolidate and extent CSP management fix(GS): consolidate and extend CSP management May 16, 2024
@juliusknorr juliusknorr self-requested a review June 15, 2024 10:09
@blizzz blizzz force-pushed the fix/noid/csp branch 4 times, most recently from 53d292a to 46a9110 Compare January 17, 2025 15:13
@blizzz

This comment was marked as resolved.

@blizzz blizzz requested a review from elzody as a code owner January 17, 2025 15:45
@blizzz blizzz changed the base branch from main to enh/noid/bumps January 17, 2025 15:46
@blizzz
Copy link
Member Author

blizzz commented Jan 17, 2025

Need to check again whether it really works after rebasing with conflict management.

Base automatically changed from enh/noid/bumps to main January 17, 2025 16:07
@blizzz blizzz added the 3. to review Waiting for reviews label Jan 21, 2025
@blizzz
Copy link
Member Author

blizzz commented Jan 27, 2025

Need to check again whether it really works after rebasing with conflict management.

Does!

Important for federation: unlock it with occ config:app:set officeonline federation_use_trusted_domains --value=yes

based on richdocument`s 398d165a5d8ff63fcc43d2e6965b1f4b4c24cada

Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz blizzz merged commit 215c1b6 into main Jan 27, 2025
45 checks passed
@blizzz blizzz deleted the fix/noid/csp branch January 27, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants