Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid unlocking too early and fix collaboration in Word #423

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 27, 2023

Fix #419

Summary

It seems that OOS sends UNLOCK requests instead of GET_LOCK with GetCurrentLock-00000000-0000-0000-0000-000000000000 as a lock token just to check the current lock. Also we still need the officeonline table for storing and comparing the lock tokens, as the server locking API currently doesn't expose methods to store a custom token.

Known issues to be documented in the README:

@juliusknorr juliusknorr added 2. developing Work in progress bug Something isn't working labels Mar 27, 2023
@juliusknorr juliusknorr marked this pull request as ready for review March 28, 2023 04:34
@luka-nextcloud
Copy link

@juliushaertl Seems like the switch-case statements are missing default case handlers.

@juliusknorr
Copy link
Member Author

@luka-nextcloud Expected in this case as we don't have a default path and just continue with the execution path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Simultanious editing broken in 2.0.0 with file_lock enabled
2 participants