Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still annot open documents shared by link #554

Closed
MatheBoZz2804 opened this issue Apr 25, 2024 · 17 comments
Closed

Still annot open documents shared by link #554

MatheBoZz2804 opened this issue Apr 25, 2024 · 17 comments

Comments

@MatheBoZz2804
Copy link

Describe the bug
When sharing a MS Office file via link, it cannot be opened by using this link.

To Reproduce
Steps to reproduce the behavior:

  1. Create a link to share the file
  2. Edit the link, e. g. prevent downloading or editing (error happens with no matter what you configure)
  3. Paste the link into a browser (no matter if on the network or from the internet)
  4. The screen keeps blank. Office is not opened

Expected behavior
When opening the link in a web browser the MS Office file should open up.

Screenshots
image
image

Client details:

  • OS: Windows 10, iOS 17,...
  • Browser: Chrome, Safari, Firefox
  • Version most recent
  • Device: PC, iPhone

Server details

Operating system: Debian 12.5 with latest patches

**Web server: Apache 2

**Database: MariaDB

PHP version: 8.1

Nextcloud version: 27.1.9

Version of the officeonline app 2.2.0, error occurs on all versions after 2.0.3, up to 2.0.3 everything is working fine!

Version of Office Online server most recent 2019 version

Logs

Nextcloud log (data/nextcloud.log)


Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...
@MatheBoZz2804 MatheBoZz2804 changed the title STill annot open documents shared by link Still annot open documents shared by link Apr 25, 2024
@MatheBoZz2804
Copy link
Author

@MatheBoZz2804
Copy link
Author

Also not working with version 28.0.5.

@MatheBoZz2804
Copy link
Author

Tried updating PHP to version 8.2: Still not working with version 2.2.0; version 2.0.3 works fine however

@johnakerlund
Copy link

Also not working with version 28.0.5.

issue also persists in version 29.0.0

@schukevich
Copy link

Can confirm, have same problem with 28.0.4, 28.0.5, 29.0.0

Opening document from folder works as expected
Editing/viewing from shared link is not working

Nextcloud log (all versions above):

QueryNotFoundException
Could not resolve OCA\Officeonline\Listener\SharingLoadAdditionalScriptsListener! Class "OCA\Officeonline\Listener\SharingLoadAdditionalScriptsListener" does not exist
Could not load event listener service OCA\Officeonline\Listener\SharingLoadAdditionalScriptsListener: Could not resolve OCA\Officeonline\Listener\SharingLoadAdditionalScriptsListener! Class "OCA\Officeonline\Listener\SharingLoadAdditionalScriptsListener" does not exist. Make sure the class is auto-loadable by the Nextcloud server container

@johnakerlund
Copy link

@juliushaertl any update on this? the patch posted in #521 has not resolved this issue, it has been a problem every version after 2.0.3

@Orchal
Copy link

Orchal commented May 10, 2024

Hi, the file lib/Listener/SharingLoadAdditionalScriptsListener.php does not exists.
It does on this branch for example: https://github.com/nextcloud/officeonline/blob/fix/add-missing-file/lib/Listener/SharingLoadAdditionalScriptsListener.php

@schukevich
Copy link

@Orchal @johnakerlund @MatheBoZz2804
Installing patch maunally worked for me, but broke my nextcloud color scheme somehow
I have NC installed with apache and php-fpm without docker, Oracle Linux 8, i went to my ../nextcloud/apps/officeonline folder and executed these commands

wget -O /tmp/officeonline-553.patch https://github.com/nextcloud/officeonline/pull/553.patch
patch -p1 < /tmp/officeonline-553.patch

then
systemctl restart httpd php-fpm and reset my browser cache
After that documents sharing working correctly.

@johnakerlund
Copy link

@schukevich i will give it another try on one of my nc-instances, what version of nextcloud and officeonline are u running?

@MatheBoZz2804
Copy link
Author

Updated to the most recent version of Office Online Integration and applied the patch. Also updated Nextcloud to version 28.0.5. Shared links can be opened again. However, when opening the link on a mobile device (no matter if Android or iPhone) you need to require the Desktop view. With the regular mobile view I receive a Not found error.
426d6dff-ac45-4987-9ecc-e175c224a3de

@johnakerlund
Copy link

@Orchal @johnakerlund @MatheBoZz2804 Installing patch maunally worked for me, but broke my nextcloud color scheme somehow I have NC installed with apache and php-fpm without docker, Oracle Linux 8, i went to my ../nextcloud/apps/officeonline folder and executed these commands

wget -O /tmp/officeonline-553.patch https://github.com/nextcloud/officeonline/pull/553.patch
patch -p1 < /tmp/officeonline-553.patch

then systemctl restart httpd php-fpm and reset my browser cache After that documents sharing working correctly.

Doing this fixed it for both version 28.0.5 & 29.0.0 (OfficeOnline version 2.2.0)

@elzody
Copy link
Contributor

elzody commented Jun 7, 2024

Released v2.2.1 which includes the missing file, so should not have to apply the patch anymore to get it working. can someone confirm it works as expected now?

@schukevich
Copy link

Released v2.2.1 which includes the missing file, so should not have to apply the patch anymore to get it working. can someone confirm it works as expected now?

Updated plugin to 2.2.1 on my instance
Not available from nextcloud app gallery right now, installed manually
Working as expected👍

@MatheBoZz2804
Copy link
Author

Hi, I‘ve just installed the new version. It still requires the desktop view.

@elzody
Copy link
Contributor

elzody commented Jun 10, 2024

@MatheBoZz2804 Hey there. Unfortunately I don't really have a way to try reproducing the mobile issue, but I will try my best to look into it sometime soon. Overall, since the Office online integration update to 2.2.1, is it working again though?

@MatheBoZz2804
Copy link
Author

MatheBoZz2804 commented Jun 10, 2024 via email

@juliusknorr
Copy link
Member

Mobile also seems out of scope of this issue, please check for other existing issues or file a new one if that is not tracked anywhere yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants