feat(scopes): List and access OpenAPI scopes #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nickvergessen
commented
Oct 28, 2023
•
nickvergessen
commented
5 tasks
provokateurin
requested changes
Nov 7, 2023
There was a problem hiding this comment.
I would prefer if only a directory iterator is used and then every match is checked instead of having two different sets of logic for the default scope and the other scopes.
I'm also not sure how getSpecPath should work here since you never pass in any app with a scope
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
feat/noid/openapi-scopes
branch
from
f63c465 to
a62a63a
Compare
provokateurin
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.