fix(OpenAPI): Fix array syntaxes #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <[email protected]>
| @@ -195,10 +195,10 @@ public function confirmIdsForUser(string $apiVersion, array $ids): DataResponse | |||
| return new DataResponse([], Http::STATUS_BAD_REQUEST); | |||
| } | |||
|
|
|||
| $ids = array_unique(array_filter(array_map( | |||
| $ids = array_values(array_unique(array_filter(array_map( | |||
There was a problem hiding this comment.
This is not what we return, so I don't really get why this is needed (just for understanding it)
There was a problem hiding this comment.
Yes, but it is cleaner to make the confirmIdsForUser() also only accept and return list<int>.
Technically not needed to change this, but I did it for completeness.
|
Sorry I accidentally deleted the comment, I didn't mean to do so. |
nickvergessen
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For nextcloud/openapi-extractor#33 and tested with nextcloud/openapi-extractor#168