Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the color-primary-element* variables #1545

Closed
wants to merge 1 commit into from
Closed

Use the color-primary-element* variables #1545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/styles/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
fill: var(--color-warning);
}
&--white {
fill: var(--color-primary-text);
fill: var(--color-primary-element-text);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those 2 colors can never diverge, both are either black or white and that does not change by the "-element" cut of :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Then it is probably fine. However I wonder if we should still normalize this here as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the problem goes even further because it still assumes it would be on primary color from the topbar, but it is on the background image, so the white might not be visible properly and instead of assigning a color we need to fall back to the normal font color, but as said. needs more testing to have clear results for all colors and states at the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

}
}

Expand Down