Perf: Improve time to render of Nextcloud via lazy-loading #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
force-pushed
the
perf/lazy-load
branch
from
cee2ced to
f351867
Compare
This will reduce the initial js bundle to be loaded on each NC page from 1.5MB to 150KB, with the rest of the code being immediately preloaded asynchronously Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
perf/lazy-load
branch
from
f351867 to
9ef3214
Compare
|
I'm not experienced with this mechanism. But I guess as long as it works it's fine? |
Signed-off-by: Joas Schilling <[email protected]>
|
Commited compiled assets. Seems to still work and audio also still plays |
nickvergessen
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will reduce the initial js bundle to be loaded on each NC page from 1.5MB to 150KB, with the rest of the code being immediately preloaded asynchronously