Skip to content

Commit

Permalink
Merge pull request #823 from nextcloud/enh/add/psalm
Browse files Browse the repository at this point in the history
Add pslam
  • Loading branch information
ChristophWurst authored Jan 7, 2021
2 parents 1794e67 + a2ef40f commit 11a0156
Show file tree
Hide file tree
Showing 5 changed files with 194 additions and 5 deletions.
26 changes: 26 additions & 0 deletions .github/workflows/static-analysis.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: Static analysis

on: [pull_request]

jobs:
static-psalm-analysis:
runs-on: ubuntu-latest
strategy:
matrix:
ocp-version: [ 'dev-master' ]
name: Nextcloud ${{ matrix.ocp-version }}
steps:
- name: Checkout
uses: actions/checkout@master
- name: Set up php
uses: shivammathur/setup-php@master
with:
php-version: 7.4
tools: composer:v1
coverage: none
- name: Install dependencies
run: composer i
- name: Install dependencies
run: composer require --dev christophwurst/nextcloud:${{ matrix.ocp-version }}
- name: Run coding standards check
run: composer run psalm
11 changes: 7 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,24 @@
"name": "nextcloud/notifications",
"description": "notifications",
"license": "AGPL",
"require": {},
"require": {
},
"require-dev": {
"phpunit/phpunit": "^8.5",
"nextcloud/coding-standard": "^0.3.0"
"nextcloud/coding-standard": "^0.3.0",
"psalm/phar": "^4.3"
},
"config": {
"optimize-autoloader": true,
"classmap-authoritative": true,
"platform": {
"php": "7.2"
"php": "7.3"
}
},
"scripts": {
"lint": "find . -name \\*.php -not -path './vendor/*' -not -path './build/*' -print0 | xargs -0 -n1 php -l",
"cs:check": "php-cs-fixer fix --dry-run --diff",
"cs:fix": "php-cs-fixer fix"
"cs:fix": "php-cs-fixer fix",
"psalm": "psalm.phar"
}
}
33 changes: 32 additions & 1 deletion composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 37 additions & 0 deletions psalm.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
<?xml version="1.0"?>
<psalm
errorLevel="4"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns="https://getpsalm.org/schema/config"
xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
errorBaseline="tests/psalm-baseline.xml"
>
<projectFiles>
<directory name="lib" />
<ignoreFiles>
<directory name="vendor" />
</ignoreFiles>
</projectFiles>
<extraFiles>
<directory name="vendor" />
<ignoreFiles>
<directory name="vendor/phpunit/php-code-coverage" />
</ignoreFiles>
</extraFiles>
<issueHandlers>
<UndefinedClass>
<errorLevel type="suppress">
<referencedClass name="OC" />
<referencedClass name="Doctrine\DBAL\Types\Types" />
</errorLevel>
</UndefinedClass>
<UndefinedDocblockClass>
<errorLevel type="suppress">
<referencedClass name="Doctrine\DBAL\Schema\Schema" />
<referencedClass name="Doctrine\DBAL\Schema\SchemaException" />
<referencedClass name="Doctrine\DBAL\Driver\Statement" />
<referencedClass name="Doctrine\DBAL\Schema\Table" />
</errorLevel>
</UndefinedDocblockClass>
</issueHandlers>
</psalm>
92 changes: 92 additions & 0 deletions tests/psalm-baseline.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="4.3.1@2feba22a005a18bf31d4c7b9bdb9252c73897476">
<file src="lib/AppInfo/Application.php">
<UndefinedClass occurrences="2">
<code>IProvider</code>
<code>IProvider</code>
</UndefinedClass>
</file>
<file src="lib/Controller/APIController.php">
<NullArgument occurrences="4">
<code>null</code>
<code>null</code>
<code>null</code>
<code>null</code>
</NullArgument>
</file>
<file src="lib/Controller/EndpointController.php">
<NullArgument occurrences="8">
<code>null</code>
<code>null</code>
<code>null</code>
<code>null</code>
<code>null</code>
<code>null</code>
<code>null</code>
<code>null</code>
</NullArgument>
</file>
<file src="lib/Controller/PushController.php">
<UndefinedClass occurrences="8">
<code>IProvider</code>
<code>IToken</code>
<code>IToken</code>
<code>IToken</code>
<code>IToken</code>
<code>InvalidTokenException</code>
<code>InvalidTokenException</code>
<code>Manager</code>
</UndefinedClass>
<UndefinedDocblockClass occurrences="4">
<code>$this-&gt;tokenProvider</code>
<code>$this-&gt;tokenProvider</code>
<code>IProvider</code>
<code>Manager</code>
</UndefinedDocblockClass>
</file>
<file src="lib/Migration/Version2004Date20190107135757.php">
<UndefinedClass occurrences="21">
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
<code>Type</code>
</UndefinedClass>
</file>
<file src="lib/Push.php">
<UndefinedClass occurrences="9">
<code>$e</code>
<code>$e</code>
<code>ClientException</code>
<code>IProvider</code>
<code>InvalidTokenException</code>
<code>Key</code>
<code>Key</code>
<code>Manager</code>
<code>ServerException</code>
</UndefinedClass>
<UndefinedDocblockClass occurrences="5">
<code>$this-&gt;keyManager</code>
<code>$this-&gt;keyManager</code>
<code>$this-&gt;tokenProvider</code>
<code>IProvider</code>
<code>Manager</code>
</UndefinedDocblockClass>
</file>
</files>

0 comments on commit 11a0156

Please sign in to comment.