-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Use text editor #958
Conversation
f228d16
to
7fa3868
Compare
7fa3868
to
cc2841c
Compare
this is already implemented, see here: #785 |
We probably should think very careful about that one. Otherwise we have the same issue as in nextcloud/text#593. Why dont we do the following:
This way we dont get into that whole discussion again, while keeping it relatively simple. The UX would be that the dropdown for the editor would also change the displayed value for the file-ending. That would not reqire any additional ui-elements. The additional benefit is that those files would also be editable without the notes app, directly from the files app. |
cc2841c
to
e608106
Compare
c57ab21
to
cac5a12
Compare
Is master not protected? |
Right, added that. |
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't read the code yet.
- I face the conflict view after editing in "rich text mode", not waiting for the top-right checkmark to say it was saved, switching to "edit mode" and making a change.
- After a change in "edit mode", even after the document has been saved (asterisk disappears in the navigation menu), switching to "rich text mode" also brings up the conflict view.
Maybe those issues are not so important as few people will switch between display modes...
Otherwise works like a charm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look at the code only. Looks good to me.
Let's handle the conflict when switching separately. We need some extra handling for ensuring that the file is saved before switching views then. |
From the old pull request
List of issues this addresses/resolves