#550 In-note-search doesn't jump to occurrence of searchstring #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic implementation which aims to always jump to the first occurrence
Added previous and next buttons (does not work yet properly)
- Fix crash on pressing prev button too often - Fix scrolling behavior in preview fragment
- Hide / show the prev / next buttons depending on the search state - Jump to next occurrence when submitting the search
- Better calculation of line of occurrence respecting also line breaks
- Fix Exception when wrapping from last to first occurrence
- Jump to last occurrence when previously selected occurrence was the first one - Hide search fabs, if only one occurrecen
Divide et impera
- Keep coloring and occurrences when switching between edit and preview mode
- Reduce calls of getLayout() for performance reasons
stefan-niedermann
deleted the
550-in-note-search-jump-to-first-occurrence
branch
stefan-niedermann
added a commit
that referenced
this pull request
Jan 23, 2020
stefan-niedermann
added a commit
that referenced
this pull request
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation which aims to always jump to the first occurrence