-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoC: Provides toolbar for native markdown editor #2209
base: main
Are you sure you want to change the base?
Conversation
Hmmm, good question. I checked the notes apps of Google and OnePlus and both have the editor bar at the bottom. @nextcloud/designers what do you think? |
Great addition :) However, I would favor a floating toolbar that is not shown at all times, but only when text is selected and an editing operation is likely to occur. As an example, this is the toolbar that pops up in signal when text is selected. |
This describes exactly the same behavior as today (see FAQ) and it will continue to work. However there are some drawbacks:
|
That said, if you really think we need this, I vote for edit bar just above the keyboard :) |
It's about consistency within the app itself. The Notes Android app ships two editors which can be toggled in the Notes Android apps settings, both with pros and cons.
This has been declined in nextcloud/notes#200 (comment) Additional context: A similar issue exists for the Notes server app (which also ships two editors). |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nice @stefan-niedermann! :) I would say editor bar at the bottom is good, since also as @AndyScherzinger said others do this.
And yes, they should be permanent for the reasons you mention, also as other apps have this too. (Also e.g. Notes on iOS.)
Signed-off-by: Stefan Niedermann <[email protected]>
45528cf
to
9473223
Compare
Currently the toolbar is positioned below the content so
However, the collaborative rich editor shows its menu bar above the content.
Which way should we go? Consistency vs. ergonomics? Or would you even consider to switch the toolbar position for the collaborative rich editor?
CC @tobiasKaminsky @AndyScherzinger
Please note that the toolbar integration might still have some bugs left which would need to be addressed in the
stefan-niedermann:nextcloud-commons
library.