set imageurl prefix to use new nextcloud-commons capabilities #1489
Conversation
| @@ -114,6 +114,7 @@ protected void onNoteLoaded(Note note) { | |||
| super.onNoteLoaded(note); | |||
| noteLoaded = true; | |||
| registerInternalNoteLinkHandler(); | |||
| binding.singleNoteContent.setMarkdownImageUrlPrefix(repo.getAccountById(note.getAccountId()).getUrl()+"/index.php/apps/notes/notes/"+note.getRemoteId()+"/attachment?path="); | |||
There was a problem hiding this comment.
This uses the internal API of the notes app. This is not intended (and will not always work). Please wait for nextcloud/notes#826 to be implemented and then use the official API!
There was a problem hiding this comment.
okay, now i have to say i am still confused about what you mean with internal API.
The only difference between above endpoint and the notes_api-routes are that the latter do have a requirement-version, but besides that i cant see a difference. Is it only semantic and therefore "locked" down? Because most other apps that i have contributed to didn't really check for that (Which isn't really the best style, but yeah.)
There was a problem hiding this comment.
The internal API is used by the web app, only. It has no public contract, so it can be changed at any time without information to third-party developers. It is fitted to the demands of the web app and not to the demands of third-party apps like mobile apps (e.g. which have an offline mode).
In contrast to this, the public API has a public documentation as well as continuous integration tests, it changes very seldom, changes must be backwards-compatible (create an incompatible new major API version should be used with caution) and it is fitted to the needs of mobile apps.
AndyScherzinger
force-pushed
the
feature/1051/imageattachments
branch
from
5b309a4 to
d43a11e
Compare
|
Rebased due to major technical updates in terms of libraries, especially AGP and SSO |
AndyScherzinger
force-pushed
the
feature/1051/imageattachments
branch
from
d43a11e to
1c92b16
Compare
This sets the url prefix in nextcloud-commons:markdown
It requires newhinton:feature/noid/imageurl, until a version with this pr is released, it is nessessary to add a local version of that branch to be used by the notes app.
This pr is tiny, and only supports images. The web-app does support arbitrary attachments, and provides a download for those. However, i think i broke mardown-conventions in doing so, so we may or may not want to support it here aswell. If we do want to support it, i have to change the library to make it work.
Also, when images cannot be loaded, we currently only show a broken image, shouldnt we also display the alt-text?
closes #1051
Oh, and i didnt check if servers that override index.php work, since the note object did not provide the "basepath", just the fqdn (or ip adress in my case)