Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextcloud_test): Handle port already used with retries #2770

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

provokateurin
Copy link
Member

Forgotten in #2769.

On the host network we don't get the 125 status code anymore if the port was already allocated, but just 1. We can't distinguish that from any other failure, so just using retries should do the trick to avoid false positives in case the port is already used.

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.88%. Comparing base (0388713) to head (eecfc5f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2770   +/-   ##
=======================================
  Coverage   28.88%   28.88%           
=======================================
  Files         373      373           
  Lines      138192   138192           
=======================================
  Hits        39923    39923           
  Misses      98269    98269           
Flag Coverage Δ *Carryforward flag
account_repository 98.47% <ø> (ø)
cookie_store 99.48% <ø> (ø) Carriedforward from 0388713
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø) Carriedforward from 0388713
dynamite_end_to_end_test 61.75% <ø> (ø) Carriedforward from 0388713
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 0388713
interceptor_http_client 97.18% <ø> (ø) Carriedforward from 0388713
neon_dashboard 96.05% <ø> (ø) Carriedforward from 0388713
neon_framework 59.34% <ø> (ø)
neon_http_client 94.32% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from 0388713
neon_rich_text 100.00% <ø> (ø)
neon_storage 94.66% <ø> (ø)
neon_talk 99.45% <ø> (ø) Carriedforward from 0388713
nextcloud 24.36% <ø> (ø)
notifications_app 97.36% <ø> (ø)
notifications_push_repository 98.11% <ø> (ø) Carriedforward from 0388713
sort_box 90.90% <ø> (ø) Carriedforward from 0388713
talk_app 98.84% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@provokateurin provokateurin merged commit 4db73c7 into main Jan 25, 2025
11 checks passed
@provokateurin provokateurin deleted the fix/nextcloud_test/container-port-already-used branch January 25, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant