Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: Migrate to pub workspace #2704

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

provokateurin
Copy link
Member

I'm not sure it will work right away, but let's see 🚀

@provokateurin provokateurin force-pushed the build/migrate_pub_workspace branch 3 times, most recently from 94fabbf to c882b3a Compare December 12, 2024 10:21
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.90%. Comparing base (f9a1b06) to head (0c0d0dd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/nextcloud/lib/src/models/version_check.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2704   +/-   ##
=======================================
  Coverage   28.90%   28.90%           
=======================================
  Files         373      373           
  Lines      136645   136645           
=======================================
+ Hits        39497    39498    +1     
+ Misses      97148    97147    -1     
Flag Coverage Δ *Carryforward flag
account_repository 98.47% <ø> (ø)
cookie_store 99.48% <ø> (ø)
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø)
dynamite_end_to_end_test 61.69% <ø> (ø)
dynamite_runtime 85.40% <ø> (ø)
interceptor_http_client 97.18% <ø> (ø)
neon_dashboard 96.05% <ø> (ø) Carriedforward from f9a1b06
neon_framework 59.34% <ø> (ø)
neon_http_client 94.32% <ø> (+0.70%) ⬆️
neon_notifications 100.00% <ø> (ø) Carriedforward from f9a1b06
neon_rich_text 100.00% <ø> (ø)
neon_storage 94.66% <ø> (ø)
neon_talk 99.45% <ø> (ø) Carriedforward from f9a1b06
nextcloud 24.33% <0.00%> (ø)
notifications_app 97.36% <ø> (ø)
notifications_push_repository 98.11% <ø> (ø)
sort_box 90.90% <ø> (ø)
talk_app 98.83% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...ckages/nextcloud/lib/src/models/version_check.dart 64.70% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial feedback

.github/workflows/conventional_commits.yaml Outdated Show resolved Hide resolved
Comment on lines 18 to +19
neon_lints:
git:
url: https://github.com/nextcloud/neon
path: packages/neon_lints
path: ../../../neon_lints
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have it as a dev_dependency of the workspace package and just use a global analysis_options.yaml.

Every package may still alter the rule set but this would make our lints the default (also for newly added packages).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think about this, but yes it makes sense. How are we going to handle custom_lint though? We need to disable some of the rules for specific packages?
OTOH this brings up the point of removing custom_lint entirely, given that it mostly causes headaches and hasn't caught so many problems so far.

tool/setup.sh Outdated Show resolved Hide resolved
@provokateurin provokateurin force-pushed the build/migrate_pub_workspace branch from 4202ca1 to 26d8793 Compare December 23, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants