-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build!: Migrate to pub workspace #2704
base: main
Are you sure you want to change the base?
Conversation
94fabbf
to
c882b3a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2704 +/- ##
=======================================
Coverage 28.90% 28.90%
=======================================
Files 373 373
Lines 136645 136645
=======================================
+ Hits 39497 39498 +1
+ Misses 97148 97147 -1
*This pull request uses carry forward flags. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some initial feedback
neon_lints: | ||
git: | ||
url: https://github.com/nextcloud/neon | ||
path: packages/neon_lints | ||
path: ../../../neon_lints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have it as a dev_dependency of the workspace package and just use a global analysis_options.yaml
.
Every package may still alter the rule set but this would make our lints the default (also for newly added packages).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think about this, but yes it makes sense. How are we going to handle custom_lint though? We need to disable some of the rules for specific packages?
OTOH this brings up the point of removing custom_lint entirely, given that it mostly causes headaches and hasn't caught so many problems so far.
c882b3a
to
0c0d0dd
Compare
0c0d0dd
to
4202ca1
Compare
Signed-off-by: provokateurin <[email protected]>
4202ca1
to
26d8793
Compare
I'm not sure it will work right away, but let's see 🚀