-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dynamite): json schema reference resolving #1953
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1953 +/- ##
==========================================
+ Coverage 28.97% 29.31% +0.34%
==========================================
Files 245 245
Lines 76496 76519 +23
==========================================
+ Hits 22161 22430 +269
+ Misses 54335 54089 -246
*This pull request uses carry forward flags. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this have some tests? I see that it is not breaking anything because none of the generated code has changed, but that is no guarantee it won't break in the future.
6903677
to
6cb2a05
Compare
We already had the e2e tests for this but I added some directly dynamite nevertheless |
Commit message has a typo and should be |
Signed-off-by: Nikolas Rimikis <[email protected]>
6cb2a05
to
a3c55c1
Compare
I did not find a better solution yet.
In theory this already allows us to fetch schemas fro other sources like local filesystem or remote servers.
I did not observe any performance penalty.
Towards: #933