Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dynamite): split JsonSchema into separate library #1931

Merged
merged 4 commits into from
Apr 27, 2024

Conversation

Leptopoda
Copy link
Member

This reorganizes the Schema handling by splitting of the validators and general schema handling.
Schemas are now split per types where only the relvant attributes are taken into account.

This will allow easier integration of #1247 and broader cleanups by only passing a specific schema type arround.

@Leptopoda Leptopoda requested a review from provokateurin April 16, 2024 16:10
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 75.71429% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 28.72%. Comparing base (b3124a5) to head (5626064).
Report is 5 commits behind head on main.

❗ Current head 5626064 differs from pull request most recent head ffa5b32. Consider uploading reports for the commit ffa5b32 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1931      +/-   ##
==========================================
+ Coverage   28.53%   28.72%   +0.18%     
==========================================
  Files         246      247       +1     
  Lines       81761    83379    +1618     
==========================================
+ Hits        23331    23951     +620     
- Misses      58430    59428     +998     
Flag Coverage Δ *Carryforward flag
dynamite 30.51% <75.71%> (+7.94%) ⬆️
dynamite_end_to_end_test 62.63% <ø> (+0.46%) ⬆️
dynamite_runtime 82.65% <ø> (ø) Carriedforward from 729e5ae
neon_dashboard 92.56% <ø> (ø)
neon_framework 38.36% <ø> (ø)
neon_talk 96.67% <ø> (ø)
nextcloud 25.69% <ø> (+<0.01%) ⬆️
sort_box 90.90% <ø> (ø) Carriedforward from 729e5ae

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
.../dynamite/dynamite/lib/src/models/json_schema.dart 100.00% <100.00%> (ø)
.../dynamite/lib/src/models/json_schema/schema.g.dart 40.40% <ø> (ø)
...ages/dynamite/dynamite/lib/src/models/openapi.dart 100.00% <100.00%> (ø)
...te/dynamite/lib/src/models/openapi/components.dart 100.00% <ø> (ø)
...namite/dynamite/lib/src/models/openapi/header.dart 25.00% <ø> (ø)
...te/dynamite/lib/src/models/openapi/media_type.dart 50.00% <ø> (ø)
...ynamite/dynamite/lib/src/models/json_schema.g.dart 98.00% <98.00%> (ø)
...es/dynamite/dynamite/lib/src/models/openapi.g.dart 78.43% <0.00%> (-3.24%) ⬇️
.../dynamite/lib/src/models/openapi/components.g.dart 40.32% <50.00%> (ø)
...ite/dynamite/lib/src/models/openapi/parameter.dart 5.31% <0.00%> (-0.06%) ⬇️
... and 4 more

... and 28 files with indirect coverage changes

@Leptopoda Leptopoda force-pushed the refactor/dynamite/json_schema_library branch from b525e70 to 118b0e8 Compare April 20, 2024 10:05
@Leptopoda Leptopoda changed the base branch from main to feat/nextcloud/29 April 20, 2024 10:06
@provokateurin provokateurin force-pushed the feat/nextcloud/29 branch 5 times, most recently from 9a18a95 to 1f39624 Compare April 25, 2024 06:13
Base automatically changed from feat/nextcloud/29 to main April 25, 2024 06:38
@Leptopoda Leptopoda force-pushed the refactor/dynamite/json_schema_library branch from 118b0e8 to 5d43ecd Compare April 25, 2024 08:49
@Leptopoda Leptopoda requested a review from provokateurin April 25, 2024 08:49
@Leptopoda Leptopoda force-pushed the refactor/dynamite/json_schema_library branch from 5d43ecd to aae8861 Compare April 25, 2024 10:19
@Leptopoda Leptopoda requested a review from provokateurin April 25, 2024 10:19
@Leptopoda Leptopoda force-pushed the refactor/dynamite/json_schema_library branch 2 times, most recently from 49dde87 to 5626064 Compare April 25, 2024 18:37
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second commit should also rename SchemaType to JsonSchemaType. Everything else LGTM

@Leptopoda Leptopoda force-pushed the refactor/dynamite/json_schema_library branch from 5626064 to ffa5b32 Compare April 27, 2024 08:51
@Leptopoda Leptopoda requested a review from provokateurin April 27, 2024 08:51
@Leptopoda Leptopoda enabled auto-merge April 27, 2024 08:53
@Leptopoda Leptopoda merged commit fccc984 into main Apr 27, 2024
8 checks passed
@Leptopoda Leptopoda deleted the refactor/dynamite/json_schema_library branch April 27, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants