-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(dynamite): split JsonSchema into separate library #1931
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1931 +/- ##
==========================================
+ Coverage 28.53% 28.72% +0.18%
==========================================
Files 246 247 +1
Lines 81761 83379 +1618
==========================================
+ Hits 23331 23951 +620
- Misses 58430 59428 +998
*This pull request uses carry forward flags. Click here to find out more.
|
b525e70
to
118b0e8
Compare
9a18a95
to
1f39624
Compare
118b0e8
to
5d43ecd
Compare
5d43ecd
to
aae8861
Compare
49dde87
to
5626064
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second commit should also rename SchemaType to JsonSchemaType. Everything else LGTM
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
…on in ofs generation Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
5626064
to
ffa5b32
Compare
This reorganizes the
Schema
handling by splitting of the validators and general schema handling.Schemas are now split per types where only the relvant attributes are taken into account.
This will allow easier integration of #1247 and broader cleanups by only passing a specific schema type arround.