chore(nextcloud): Update specs to 28.0.1 #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leptopoda
reviewed
Dec 21, 2023
There was a problem hiding this comment.
LGTM.
The unit tests do not need to be in NC if it is hard to reproduce both available cases.
Maybe add a dynamite_e2e test with oneof(int|array<int>) and oneof(String|array<Object>) (the later one being used in '/ocs/v2.php/apps/spreed/api/{apiVersion}/signaling/{token}'
|
The spreed case of |
Signed-off-by: jld3103 <[email protected]>
provokateurin
force-pushed
the
chore/nextcloud/update-specs
branch
from
9b6039f to
ab350b2
Compare
Closed
|
I think we can merge this already because the bug is in dynamite and doesn't block this change. |
Leptopoda
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1226
Draft for now, I'll wait until 28.0.1 has been tagged on server and notifications (although there are no diffs using the stable28 branches).