refactor(nextcloud): Reuse containers in tests #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
refactor/nextcloud/reuse-containers
branch
from
57a754b to
f2f236b
Compare
|
I like the approach.
Shure; Please |
Leptopoda
reviewed
Dec 20, 2023
|
I'm giving up on the news tests for now. The spec and tests need to be rewritten completely (not even talking about generating them). They are the oldest part of this project and it really shows. |
provokateurin
force-pushed
the
refactor/nextcloud/reuse-containers
branch
from
f2f236b to
2e4d272
Compare
Leptopoda
approved these changes
Dec 21, 2023
Signed-off-by: jld3103 <[email protected]>
provokateurin
force-pushed
the
refactor/nextcloud/reuse-containers
branch
from
2e4d272 to
192c128
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1300
It was possible to migrate some of the test suite without even changing the test content or fixtures. I could extract those into a separate PR so we can get those merged already. I'm not sure how long it will take to merge this complete PR, so we might want to do this to get some small improvements already.
@Leptopoda please let me know if you like this approach. It makes all tests very fast, except for news which I haven't migrated yet as it is quite hard. I might do some profiling of the news app to check why it is so slow in the first place and if that could be solved at all. If it turns out that adding the feed is slow then we won't really get much benefit from reusing the same container.