-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump CKEditor to v26 #4702
Bump CKEditor to v26 #4702
Conversation
fails because of npm7. will be better after #4706 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we merge?
Let's wait because linter fails |
389d4e4
to
a81ac44
Compare
Please give this a quick retest :) |
works good 👍 |
es lint fails again 😢
|
This error can be fixed by replacing the deprecated package |
You are our hero. I've debugged this for like 20min and couldn't figure that out 🙊 |
I would love to hear how he debugged that |
I for one got lost in this ticket: babel/babel#12857 |
This error seems to be all over the place. I looked at babel/babel-eslint#799 (comment). Running eslint just works after replacing the package with @babel/eslint-parser 🤷♂️ |
Signed-off-by: Christoph Wurst <[email protected]>
a81ac44
to
f6fe505
Compare
The editor still renders 👍