Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CKEditor to v26 #4702

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

ChristophWurst
Copy link
Member

The editor still renders 👍

@ChristophWurst
Copy link
Member Author

fails because of npm7. will be better after #4706

Copy link
Collaborator

@StCyr StCyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it works

Copy link
Collaborator

@StCyr StCyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we merge?

@ChristophWurst
Copy link
Member Author

Let's wait because linter fails

@ChristophWurst ChristophWurst force-pushed the dependachristoph/npm_and_yarn/ckeditor-26 branch from 389d4e4 to a81ac44 Compare March 9, 2021 09:20
@ChristophWurst
Copy link
Member Author

Please give this a quick retest :)

@StCyr
Copy link
Collaborator

StCyr commented Mar 9, 2021

works good 👍

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Mar 9, 2021

es lint fails again 😢

TypeError: Cannot read property 'range' of null
Occurred while linting /home/runner/work/mail/mail/src/components/TextEditor.vue:129

@st3iny
Copy link
Member

st3iny commented Mar 9, 2021

This error can be fixed by replacing the deprecated package babel-eslint with @babel/eslint-parser in nextcloud/eslint-config and our package.json.

@ChristophWurst
Copy link
Member Author

This error can be fixed by replacing the deprecated package babel-eslint with @babel/eslint-parser in nextcloud/eslint-config and our package.json.

You are our hero. I've debugged this for like 20min and couldn't figure that out 🙊

@StCyr
Copy link
Collaborator

StCyr commented Mar 9, 2021

This error can be fixed by replacing the deprecated package babel-eslint with @babel/eslint-parser in nextcloud/eslint-config and our package.json.

You are our hero. I've debugged this for like 20min and couldn't figure that out 🙊

I would love to hear how he debugged that

@ChristophWurst
Copy link
Member Author

I for one got lost in this ticket: babel/babel#12857

@st3iny
Copy link
Member

st3iny commented Mar 9, 2021

This error seems to be all over the place. I looked at babel/babel-eslint#799 (comment). Running eslint just works after replacing the package with @babel/eslint-parser 🤷‍♂️

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst force-pushed the dependachristoph/npm_and_yarn/ckeditor-26 branch from a81ac44 to f6fe505 Compare March 10, 2021 10:13
@ChristophWurst ChristophWurst merged commit 56b9c98 into master Mar 10, 2021
@ChristophWurst ChristophWurst deleted the dependachristoph/npm_and_yarn/ckeditor-26 branch March 10, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants