Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to view admin_audit log files #857

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

LakshayaTohan
Copy link

Add a LogFileProvider class that identifies the available log files It checks if the admin_audit app is enabled, and fetches it's logfile path.

Additionally, add ability for user to select the file they want to view. The "Download logs" button now downloads the currently selected log file.

Tested by enabling/disabling admin_audit app, toggling "Log file"

Add a LogFileProvider class that identifies the available log files
It checks if the admin_audit app is enabled, and fetches it's logfile
path.

Additionally, add ability for user to select the file they want to
view. The "Download logs" button now downloads the currently selected
log file.

Tested by enabling/disabling admin_audit app, toggling "Log file"

Signed-off-by: Lakshaya Tohan <[email protected]>
This fixes an error: Optional parameter $levels declared before required parameter $logfile is implicitly treated as a required parameter

Signed-off-by: Lakshaya Tohan <[email protected]>
@joshtrichards
Copy link
Member

I haven't had an opportunity to look closely at the code yet, but I like the idea.

Some of this is based on #476, correct?

This would certainly further address #318 / #129 w/o forcing the admin to use consolidated logging (see nextcloud/documentation#10604).

P.S. Looks like one of your commits isn't signed so the tests can't run. A rebase to master probably a.good idea while you're at it. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants