Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LogErrors): Handle unsupported log_type gracefully #1449

Merged

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Dec 18, 2024

Fixes #1448

Before After
image imageimage

@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin
Copy link
Member Author

/backport to stable29

@provokateurin
Copy link
Member Author

/backport to stable28

Copy link
Collaborator

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. tested with tweaking config

@provokateurin provokateurin merged commit 7dc9fb2 into master Dec 18, 2024
30 checks passed
@provokateurin provokateurin deleted the fix/logerrors/handle-unsupported-log_type-gracefully branch December 18, 2024 19:08
provokateurin added a commit to provokateurin/nixpkgs that referenced this pull request Jan 8, 2025
The error is no longer logged since nextcloud/logreader#1449.
This was a bug in the app, since the error is not fixable by the admin due to the logging configuration.
provokateurin added a commit to provokateurin/nixpkgs that referenced this pull request Jan 8, 2025
The error is no longer logged since nextcloud/logreader#1449.
This was a bug in the app, since the error is not fixable by the admin due to the logging configuration.
provokateurin added a commit to provokateurin/nixpkgs that referenced this pull request Jan 8, 2025
The error is no longer logged since nextcloud/logreader#1449.
This was a bug in the app, since the error is not fixable by the admin due to the logging configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup check fails while it should skip non-file log_types
2 participants