Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak list formatting #398

Closed
wants to merge 4 commits into from

Conversation

Richardds
Copy link
Contributor

Pull Request

Description of the change

The current list formatting across the project is not uniform. This MR tweaks the list formatting in all YAML files.

Benefits

Uniform list formatting

Possible drawbacks

Applicable issues

Additional information

Checklist

Richardds added 2 commits May 18, 2023 16:20
Signed-off-by: Richard Boldiš <[email protected]>
Signed-off-by: Richard Boldiš <[email protected]>
@Richardds Richardds mentioned this pull request May 18, 2023
3 tasks
@jessebot jessebot self-requested a review August 20, 2023 06:57
Copy link
Collaborator

@jessebot jessebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine to do, though curious how you formatted these, if you used any tools :) Please resolve the conflicts and we can probably get this merged.

@Richardds
Copy link
Contributor Author

Hey @jessebot , I resolved the conflicts.

@jessebot
Copy link
Collaborator

Thanks, @Richardds. Sorry to bother you again, but can you bump the helm chart version a patch version? Thank you! It needs to be 4.3.2 right now.

@jessebot
Copy link
Collaborator

@wrenix Can you confirm if this was taken care of in your PR we merged the other day?

@wrenix
Copy link
Collaborator

wrenix commented Nov 21, 2023

i believe we should do the other way around, to indent the list.

myself i prefer:

a:
  - a
  - b

over this PR, which would create:

a:
- a
- b

@jessebot
Copy link
Collaborator

I agree with you @wrenix, the indentation makes it easier to read. 👍 I just wasn't sure if that was already taken care of by your PR from the other day.

@Richardds Can you rebase and adjust the lists to include indentation if it's still required? Quite a bit of linting was done here: #465

@jessebot jessebot added the 1. to develop Accepted and waiting to be taken care of label Nov 21, 2023
@jessebot
Copy link
Collaborator

I'm going to close this as I agree with @wrenix in #398 (comment) and since #465 was merged, it's all much much more consistent. Thank you for your PR and time regardless 🙏

@jessebot jessebot closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants