-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak list formatting #398
Conversation
Signed-off-by: Richard Boldiš <[email protected]>
Signed-off-by: Richard Boldiš <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably fine to do, though curious how you formatted these, if you used any tools :) Please resolve the conflicts and we can probably get this merged.
Signed-off-by: Richard Boldiš <[email protected]>
Hey @jessebot , I resolved the conflicts. |
Signed-off-by: JesseBot <[email protected]>
Thanks, @Richardds. Sorry to bother you again, but can you bump the helm chart version a patch version? Thank you! It needs to be |
@wrenix Can you confirm if this was taken care of in your PR we merged the other day? |
i believe we should do the other way around, to indent the list. myself i prefer: a:
- a
- b over this PR, which would create: a:
- a
- b |
I agree with you @wrenix, the indentation makes it easier to read. 👍 I just wasn't sure if that was already taken care of by your PR from the other day. @Richardds Can you rebase and adjust the lists to include indentation if it's still required? Quite a bit of linting was done here: #465 |
I'm going to close this as I agree with @wrenix in #398 (comment) and since #465 was merged, it's all much much more consistent. Thank you for your PR and time regardless 🙏 |
Pull Request
Description of the change
The current list formatting across the project is not uniform. This MR tweaks the list formatting in all YAML files.
Benefits
Uniform list formatting
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver.