-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ingress snippet comment in values.yaml #241
Conversation
Could you please update the chart version and also link the most recent version of the documentation you're referencing? Other than that, it looks okay to me. Thanks for your contribution! :) |
@Northcode any chance you could revisit this PR? I can confirm this fix works. |
@Jeroen0494 |
I think @jessebot was requesting you remove the extra line between 34 and 35 in values.yaml |
@tvories |
Also, really quick, I'm a real person. I can't be rerun because I'm not a bot 😂 My username just has the word bot in it :) |
04b0f44
to
098f6dc
Compare
Update well-known webfinger and nodeinfo redirects to match documentation in https://docs.nextcloud.com/server/23/admin_manual/issues/general_troubleshooting.html#service-discovery Signed-off-by: Andreas Larsen <[email protected]>
@jessebot oh I see. In that case sorry for assuming your uhm.. type of consciousness? I guess? haha Anyways I've removed the whitespace now on both line 36 and 33 and rebased onto upstream again, incrementing the chart version to 3.5.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chart.yaml needs bumping. Left the suggestion so you can just click the button and we can merge this. Thank you for fixing the whitespace :)
Signed-off-by: JesseBot <[email protected]>
Signed-off-by: JesseBot <[email protected]>
Pull Request
Description of the change
Update well-known webfinger and nodeinfo redirects to match documentation in https://docs.nextcloud.com/server/23/admin_manual/issues/general_troubleshooting.html#service-discovery
Benefits
People just uncommenting the snippet will now have correct webfinger config, and no warnings in the nextcloud settings.
Possible drawbacks
None that I can see
Applicable issues
#240
Additional information
...
Checklist
Chart.yaml
according to semver.