Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Sharing): Do not create new share in guest app #1189

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Jun 24, 2024

Only create the template for share and return the the 'Sharing UI' in the sidebar

@nfebe nfebe force-pushed the fix/sharing-emit-event-4-new-share branch 2 times, most recently from a09bb9d to 4bb6956 Compare June 24, 2024 13:57
@nfebe nfebe changed the title WIP(Sharing): Emit event for newly created guest share fix(Sharing): Do not create new share in guest app Jun 24, 2024
Only create the template for share and return the the 'Sharing UI'
in the sidebar.

Signed-off-by: fenn-cs <[email protected]>
@nfebe nfebe force-pushed the fix/sharing-emit-event-4-new-share branch from 4bb6956 to 31f6ec8 Compare June 24, 2024 14:02
@nfebe nfebe marked this pull request as ready for review June 24, 2024 14:05
@nfebe nfebe requested a review from PVince81 June 24, 2024 14:05
@nfebe nfebe assigned susnux and artonge and unassigned susnux and artonge Jun 24, 2024
@nfebe nfebe requested review from susnux, artonge, skjnldsv and Pytal June 24, 2024 14:06
@nfebe
Copy link
Contributor Author

nfebe commented Jun 24, 2024

/backport to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jun 24, 2024
@nfebe
Copy link
Contributor Author

nfebe commented Jun 24, 2024

/backport to stable2.5

@nfebe
Copy link
Contributor Author

nfebe commented Jun 24, 2024

/backport to stable2.4

@nfebe nfebe merged commit aa23b0a into master Jun 24, 2024
39 checks passed
@nfebe nfebe deleted the fix/sharing-emit-event-4-new-share branch June 24, 2024 17:13
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Jun 24, 2024
@skjnldsv skjnldsv mentioned this pull request Oct 22, 2024
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants