Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enforce strict types everywhere #3234

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: Enforce strict types everywhere #3234

wants to merge 1 commit into from

Conversation

provokateurin
Copy link
Member

Depends on nextcloud/server#48094 as View.php can't handle false for getOwner() everywhere.
All untouched files already had it enabled.

@provokateurin provokateurin added 3. to review Items that need to be reviewed technical debt labels Sep 16, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Sep 16, 2024
@provokateurin provokateurin marked this pull request as draft September 16, 2024 14:47
@provokateurin
Copy link
Member Author

Interesting, in CI it doesn't fail without the PR mentioned above.

@provokateurin
Copy link
Member Author

Code coverage in groupfolders is only around 30% which is way to little to turn this on with confidence.

@provokateurin provokateurin mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala Awaiting requested review from miaulalala

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
3. to review Items that need to be reviewed technical debt
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
1 participant
@provokateurin