fix(ACL): Add check to prevent users from revoking their own access

[icewind1991]

When changing ACL rules, check if the new rule set would lead the current user without read permissions

• make the UI properly handle the error
• (maybe) add an option to force revoking the access anyway

[jancborchardt]

@icewind1991 since you said

Would it maybe make more sense to just fully prevent users from revoking their own access?

I would say the modal is better, because maybe you do want to get out of the group folder?

Access removal
Proceeding will remove your own access to this group folder.
[ Cancel ] [ Remove own access ]

[provokateurin]

Fixes #2822

[provokateurin]

I would say the modal is better, because maybe you do want to get out of the group folder?

I don't think this makes sense, since in fact you do not remove yourself from the Team folder this way.
If the user no longer wants access, then an admin has to remove their access and they can not do it themselves through ACL (which also only works on sub folders, not the root Team folder itself anyway).

[provokateurin]

/backport to stable31

[Jerome-Herbinet]

Hi, awesome improvement ! Can't it be backported to some previous major releases @icewind1991 @jancborchardt ?

[provokateurin]

Let's try!

[provokateurin]

/backport to stable30

[provokateurin]

/backport to stable29

[provokateurin]

@Jerome-Herbinet stable30 was relatively easy to do, but stable29 unfortunately would need a larger amount of work, so not backporting it there.

[Jerome-Herbinet]

@Jerome-Herbinet stable30 was relatively easy to do, but stable29 unfortunately would need a larger amount of work, so not backporting it there.

Thanks for your answer @provokateurin. Can you tell me when the next version of Team Folders for Nextcloud 30 (> 18.1.0) will be released (the version that will include this new backported feature)? and what precise version number ? I assume : 18.1.1 ?

[provokateurin]

I can do it next Monday, should be 18.1.1 indeed.

[Jerome-Herbinet]

I can do it next Monday, should be 18.1.1 indeed.

It would be great @provokateurin ! I'm currently making (and scheduling) a communication talking about this for next Tuesday (on Arawa's Mastodon, BlueSky and LinkedIn pages).