Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds github ISSUE TEMPLATES #1416

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Adds github ISSUE TEMPLATES #1416

merged 1 commit into from
Apr 14, 2021

Conversation

pierreozoux
Copy link
Member

Like the one from server.

Signed-off-by: pierreozoux [email protected]

@pierreozoux pierreozoux mentioned this pull request Apr 2, 2021
Open
@fschrempf
Copy link
Contributor

Having issue templates is definitely a good thing, but the ones from the server seem a bit too long and confusing to me. And also we can't use them as-is, as there are references to the server repository and other things that would need changes. See my inline comments.

@pierreozoux
Copy link
Member Author

Ok, was a bit fast, Ill review next weekand improve thanks for feedback.

@pierreozoux
Copy link
Member Author

Ok, sorry :)

I think I fixed the PR, ready to be reviewd one more time :)

@pierreozoux pierreozoux added 3. to review Items that need to be reviewed enhancement labels Apr 9, 2021
@fschrempf
Copy link
Contributor

Ok, sorry :)

I think I fixed the PR, ready to be reviewd one more time :)

No worries! Thanks!

Can you squash all the commits into one and force-push? I think we are ready to merge then and this should also fix the DCO check issue as your first commit is signed-off correctly.

@pierreozoux pierreozoux force-pushed the issue_template branch 3 times, most recently from 1862099 to 261914a Compare April 14, 2021 08:14
@pierreozoux
Adds github ISSUE TEMPLATES
b9d7a0b 
Like the one from server.

Signed-off-by: pierreozoux <[email protected]>
@pierreozoux
Copy link
Member Author

In GitLab you can merge/squash.. it is always a mess to rebase/force push.. anyway :) It is done :)

@fschrempf fschrempf merged commit d060e44 into nextcloud:master Apr 14, 2021
@pierreozoux pierreozoux deleted the issue_template branch April 16, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschrempf fschrempf fschrempf approved these changes

@icewind1991 icewind1991 icewind1991 approved these changes

Assignees
No one assigned
Labels
3. to review Items that need to be reviewed enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierreozoux @fschrempf @icewind1991