Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take trashbin retention policy into account #930

Closed
juliusknorr opened this issue May 28, 2020 · 7 comments
Closed

Take trashbin retention policy into account #930

juliusknorr opened this issue May 28, 2020 · 7 comments
Labels
1. to develop Issues that are ready for development enhancement feature: trashbin Items related to the trashbin feature high high priority integration

Comments

@juliusknorr
Copy link
Member

Since the groupfolders app has its own trash backend, the regular background job for applying the retention policy does not act on files in the group folders trashbin: https://github.com/nextcloud/server/blob/afbd9c4e6ed834e713039f2cff88ba3eec03dadb/apps/files_trashbin/lib/BackgroundJob/ExpireTrash.php#L89
@juliusknorr juliusknorr added enhancement 1. to develop Issues that are ready for development labels May 28, 2020
@freiheitswolke-org
Copy link

Hey,
we opened a bounty on this missing function.
Please spread the voice and contribute as you can:
https://www.bountysource.com/issues/69919948-tashbin-cannot-be-cleared-with-group-folder-data

@juliusknorr juliusknorr mentioned this issue Aug 7, 2020
Closed
2 tasks
@rakekniven rakekniven changed the title Take tashbin retention policy into account Take trashbin retention policy into account Oct 7, 2020
@landryb
Copy link

landryb commented Oct 12, 2020

is #1064 fixing that or just a temporary workaround to add to cron ?

@juliusknorr
Copy link
Member Author

#1064 is a temporary workaround to clear the whole trashbin, a proper retention implementation is started with #991

@pierreozoux pierreozoux mentioned this issue Mar 14, 2021
Closed
@pierreozoux pierreozoux added the feature: trashbin Items related to the trashbin feature label Mar 14, 2021
@pierreozoux pierreozoux mentioned this issue Mar 14, 2021
Closed
@jngrb
Copy link
Contributor

jngrb commented Oct 15, 2021

Please indicate what the development status is. Also in my project, nextcloud hosting for an NGO, we are in desperate need of a solution and would like how the Nextcloud team wants to proceed and whether we can help getting this fixed.

@fschrempf fschrempf added the high high priority label Nov 5, 2021
CarlSchwan added a commit that referenced this issue Nov 19, 2021
@CarlSchwan
Respect quota + add background job
874d80d 
Fix #930

Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan
Copy link
Member

New PR: #1759. It would be great to get some community testing.

CarlSchwan added a commit that referenced this issue Nov 19, 2021
@CarlSchwan
Respect quota + add background job
b887742 
Fix #930

Signed-off-by: Carl Schwan <[email protected]>
@fschrempf
Copy link
Contributor

Closing in favor of #1759.

backportbot-nextcloud bot pushed a commit that referenced this issue Nov 25, 2021
@CarlSchwan @backportbot
Respect quota + add background job
eed1bdc 
Fix #930

Signed-off-by: Carl Schwan <[email protected]>
@fschrempf fschrempf mentioned this issue Nov 26, 2021
Closed
@pgassmann
Copy link

FYI, group folders 11.1 for Nextcloud 23 is released. occ groupfolders:expire will now clean up the trashbin of groupfolders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Issues that are ready for development enhancement feature: trashbin Items related to the trashbin feature high high priority integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expire group folders trashbin nextcloud/groupfolders
8 participants
@pgassmann @pierreozoux @juliusknorr @landryb @jngrb @CarlSchwan @fschrempf @freiheitswolke-org