Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of getEventDispatcher() #159

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Sep 16, 2024

getEventDispatcher() is removed in 29

@ArtificialOwl
Copy link
Member Author

/backport to stable28

@ShGKme
Copy link
Contributor

ShGKme commented Sep 16, 2024

No backport for 29 and 30?

@ArtificialOwl
Copy link
Member Author

stable28 is compat until 30

Signed-off-by: Maxence Lange <[email protected]>
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/deprecated-event-dispatcher branch from f444094 to 1185a10 Compare September 16, 2024 18:59
@ArtificialOwl ArtificialOwl merged commit 56fa23d into master Sep 16, 2024
19 checks passed
@ArtificialOwl ArtificialOwl deleted the fix/noid/deprecated-event-dispatcher branch September 16, 2024 19:53
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use Symfony\Component\EventDispatcher\GenericEvent;

should be

use OCP\EventDispatcher\GenericEvent;

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants