Remove obsolete/faulty css for the top right button

[eppfel]

Fixes wrong styling in files app and gallery due to new button styles in server nextcloud/server#3187

[codecov-io]

Codecov Report

Merging #196 into master will decrease coverage by 0.46%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #196      +/-   ##
============================================
- Coverage     82.39%   81.93%   -0.47%     
  Complexity      334      334              
============================================
  Files            38       38              
  Lines          1284     1284              
============================================
- Hits           1058     1052       -6     
- Misses          226      232       +6

Impacted Files	Coverage Δ	Complexity Δ
lib/Middleware/SharingCheckMiddleware.php	85% <0%> (-15%)	7% <0%> (ø)
lib/Middleware/EnvCheckMiddleware.php	89.39% <0%> (-4.55%)	24% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d7b1d2...8074f5c. Read the comment docs.

[skjnldsv]

Could you use a span and apply the icon through css instead?
Like the other buttons on the files?

I would like to unify the alignment of icons inside buttons in core :)

[eppfel]

@skjnldsv Feel free to hijack this...

[skjnldsv]

@eppfel sorry, here you go :)
We should test it in nc11.

[oparoz]

Is there a way to keep the alternative text for the icon?

[skjnldsv]

With title?

[oparoz]

It currently says "Gallery view", letting people know what the button is for. It's also an accessibility thing if I'm not mistaken.

[skjnldsv]

Alt is in case of the image isn't loaded indeed. With title we should be able to have a popup. That's how we do on the other apps on nextcloud I think. There isn't any icons used as direct image (not that I'm aware of at least) :)

[oparoz]

Just tested on Files and seems all of these are gone anyway, so if @jancborchardt is OK with this, it can be merged.

[jancborchardt]

Can you post a before/after screenshot? Not sure what the issue is.

It is intentional that the switch to Gallery in the top right of files does not have a border.

[MorrisJobke]

@eppfel What is the status of this? Could you show what is broken and what does this fix to evaluate if we need to ship this with 12. I would like to move this to 13.

[eppfel]

Before:

After:

[eppfel]

Wait.. now the icon greyvalue is off... @skjnldsv to the rescue!

[MorrisJobke]

Rebased

[MorrisJobke]

BTW: I'm currently fixing all of this here 😉

[MorrisJobke]

Okay I adjusted:

• the loading icon is now not weirdly overlayed anymore on the switcher between files and gallery and it is the small version:

• all buttons are now grey (as in server) and on hover only have the blue border (like in server) - instead of the white background on hover and active state - they also now use the servers active class

• the position of the icon inside of the button is also properly centered now:

[MorrisJobke]

👍

[MorrisJobke]

And this should be backported to the stable12 branch.

[jancborchardt]

Looks good! What about the Travis failure?

[oparoz]

Looks good! What about the Travis failure?

Someone needs to adjust the acceptance test to work with the new menu introduced in 12.
https://github.com/nextcloud/gallery/blob/master/tests/acceptance/SignInAsUserCept.php#L28 requires this to be correct
https://github.com/nextcloud/gallery/blob/master/tests/_support/Page/Gallery.php#L20