Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] allow nested dependencies #388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arminfelder
Copy link

adds an insertion sort, to allow more complex dependency cases,
e.g.:

destinations:
/package1/pathy/pathz
/package1/pathx
/package1/pathx/pathq
/package1/

this change will affect the order of processing such dependencies, so that the parent dir is always processed before the children:

/package1/
/package1/pathx
/package1/pathy/pathz
/package1/pathx/pathq

without that change, it can happen, that when a parent is processed, the children get wiped
e.g.

  1. delete /package1/pathy/pathz
  2. move pathz to /package1/pathy/pathz
  3. delete /package1
  4. move package1 to /package1

…ncies in alphabetical ascending order

Signed-off-by: Armin Felder <[email protected]>
@arminfelder arminfelder force-pushed the feature/supportNestedDependencies branch from d4d62c0 to 8655e31 Compare October 26, 2024 23:00
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant