-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Nextcloud Hub changelog #1145
Conversation
c3c6d9a
to
e76ccb3
Compare
/backport to stable29 |
e76ccb3
to
541a278
Compare
541a278
to
d1032fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good other than minor remarks, did not test
@@ -0,0 +1 @@ | |||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><path d="M23.446 18l0.889-5.791h-5.557v-3.758c0-1.584 0.776-3.129 3.265-3.129h2.526v-4.93c0 0-2.292-0.391-4.484-0.391-4.576 0-7.567 2.774-7.567 7.795v4.414h-5.087v5.791h5.087v14h6.26v-14z" fill="currentColor" /></svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting an explicit width="32" height="32"
may help prevent some visual bugs on svgs
axios.delete(generateUrl('/apps/firstrunwizard/wizard')) | ||
} | ||
// Exposes open and close functions from the component | ||
defineExpose({ open, close }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
* Split `App.vue` into `App.vue` and `SlideShow.vue` * Add `WizardPage` as common base for all pages * Use `script setup` to reduce boiler plate code and better TypeScript support * Rename pages so the name makes sense Signed-off-by: Ferdinand Thiessen <[email protected]>
This adds additional slides to the wizard for changes in the current Nextcloud Hub release and for sharing it with other users. Also modified the menu entry from "About" to "About & What's new". Signed-off-by: Ferdinand Thiessen <[email protected]>
d1032fc
to
dc4f0ba
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
dc4f0ba
to
32f3d46
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Current state: Waiting for real data to include.
App.vue
intoApp.vue
andSlideShow.vue
WizardPage
as common base for all pagesscript setup
to reduce boiler plate code and better TypeScript support