-
Notifications
You must be signed in to change notification settings - Fork 37
Fix 18 public folder #152
Fix 18 public folder #152
Conversation
/backport to stable18 |
/compile amend / |
e1e0164
to
7f7d6da
Compare
/compile amend / |
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
backport to stable18 in #153 |
When it will be updated ? |
Next release: 18 |
This problem re-appeared for me after the snap update (to 18.0.4) this morning. Video player works perfectly well when logged in. On a public share I just see the spinner. Sorry, not sure if I was meant to reply here or at the original bug here: #150 |
hello klaasvakie, I've run into the same issues as you, but it seems like the public sharing with videos is now handled with viewer app, which is integrated into nextcloud directly. I've been searching all day as to why it was broken again, and found a very strange workaround... as admin in "settings", in "sharing" page and then "federated cloud sharing" section if the option "Allow users on this server to send shares to other servers" is not checked... than the video player doesn't work on public sharing... this is absolutly non-sense as i don't use federated servers, but somehow when comparing why it worked on some instances and not on the one i needed it the most, i discovered this. let me know if it worked for you too have a nice day, |
Wow @Walterfilms, no idea how you found that! But yes, it does fix the problem for me as well, thank you very much for your sleuthing. So @skjnldsv, should I file a new bug specifically around the federated sharing toggle, or are you happy to pick it up from here? |
Hey! :) |
Looks like that bug pretty much describes what I'm seeing so I'm not going to add more noise. Thanks for the help @skjnldsv!. |
@Walterfilms Thanks so much! |
Grate Work @Walterfilms |
Important fix, somehow we changed something and
FileActions
is not here.This fixes the opening of videos in a public shared folder