Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

Fix 18 public folder #152

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Fix 18 public folder #152

merged 1 commit into from
Feb 27, 2020

Conversation

skjnldsv
Copy link
Member

Important fix, somehow we changed something and FileActions is not here.
This fixes the opening of videos in a public shared folder

@skjnldsv
Copy link
Member Author

/backport to stable18

@skjnldsv
Copy link
Member Author

/compile amend /

@rullzer
Copy link
Member

rullzer commented Feb 27, 2020

/compile amend /

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@backportbot-nextcloud
Copy link

backport to stable18 in #153

@Aurnytoraink
Copy link

When it will be updated ?

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 10, 2020

Next release: 18

@klaasvakie
Copy link

klaasvakie commented Apr 25, 2020

This problem re-appeared for me after the snap update (to 18.0.4) this morning. Video player works perfectly well when logged in. On a public share I just see the spinner.

Sorry, not sure if I was meant to reply here or at the original bug here: #150

@Walterfilms
Copy link

hello klaasvakie,

I've run into the same issues as you, but it seems like the public sharing with videos is now handled with viewer app, which is integrated into nextcloud directly.

I've been searching all day as to why it was broken again, and found a very strange workaround...

as admin in "settings",

in "sharing" page and then "federated cloud sharing" section

if the option "Allow users on this server to send shares to other servers" is not checked...

than the video player doesn't work on public sharing...

this is absolutly non-sense as i don't use federated servers, but somehow when comparing why it worked on some instances and not on the one i needed it the most, i discovered this.

let me know if it worked for you too

have a nice day,

@klaasvakie
Copy link

Wow @Walterfilms, no idea how you found that! But yes, it does fix the problem for me as well, thank you very much for your sleuthing.

So @skjnldsv, should I file a new bug specifically around the federated sharing toggle, or are you happy to pick it up from here?

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 27, 2020

So @skjnldsv, should I file a new bug specifically around the federated sharing toggle, or are you happy to pick it up from here?

Hey! :)
There is already an issue about this here: nextcloud/server#20132
I'll let you read, but this is basically because federated use link shares to negotiate apparently 🤷

@klaasvakie
Copy link

Looks like that bug pretty much describes what I'm seeing so I'm not going to add more noise. Thanks for the help @skjnldsv!.

@maidstein
Copy link

@Walterfilms Thanks so much!

@freumichCH
Copy link

Grate Work @Walterfilms

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants