-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow slideshow with PDFs #620
Conversation
Signed-off-by: John Molakvoæ <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking. See my comment above
Hum, no idea how to solve that. Jan approved adding the slideshow |
yeah, but he was probably not aware about the conflict with these buttons... |
@jancborchardt @nimishavijay what do you reckon ? :) |
Nice catch @szaimen, I would put the navigation behind the menu. I just checked and that's what the Gnome image viewer is doing:
|
Suggestion by @artonge sounds good to me 🚀 |
the only problem that I see with that is that the pdfviewer is loaded in an iframe and I am not sure if it is possible to inject the overlay buttons into the iframe... cc @skjnldsv |
Nope, indeed. We'd have to think differently :( |
this sounds good to me 👍 |
How about just lowering those bottoms, and/or implementing left/right keys on devices with keyboards? There's already a handler for the escape key, why not monitor for L/R too? Actually, for esc, one needs to click on the top bar (where the X is ) first before escape works. |
Has some form of this enhancement made it into the 25.xx beta? I installed 25.0.0 RC1 into a vm but don't see any change in pdf navigation. Thank you |
@gpz1100 no, this is not merged, see assigned 26 milestone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hide them when the menu is opened
For reference, this solution sounds good to me as well. If we can get that event from the PDF viewer we can go ahead with that solution. :)
I think this is a very important feature and should be added soon as navigating through files should be easy within Nextcloud. I reckon the navigation should be added to the sidebar rather than through the slideshow feature, as it would circumvent all problems pointed out by @szaimen and would be an universal approach to all files, not just PDFs etc. Navigation buttons (previous/next file) in the sidebar would make more sense to me. |
I'm confused, is this feature currently offered or will be offered or is being discarded entirely? |
@gpz1100 Unfortunately seems the requests for this are quite low, if anyone wants to take over, feel free 👍 |
Fix #444