[stable15] Fix PDF sidebar shown in PDF thumbnails #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
The PDF viewer remembers whether the PDF sidebar was open or closed for each PDF file the last time it was viewed. Thus, when the PDF file is rendered in a thumbnail the sidebar must be explicitly hidden to ensure that it will never be shown. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
approved these changes
Nov 27, 2018
There was a problem hiding this comment.
Tested and works 👍
The version number should be bumped before the next release to prevent that the previous CSS file is got from the cache; would it be better to do it know to ensure that it is not forgotten?
Also, I am not sure if the milestone should be 15 or 15.0.1?
rullzer
approved these changes
Nov 29, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #113