upgrade app to be compatible with Nextcloud 28 (issue #159) #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please approve this modification. |
|
@susnux Would you mind ✅'ing this PR? Thanks |
appinfo/info.xml
Outdated
| @@ -24,7 +24,7 @@ | |||
| <screenshot>https://raw.githubusercontent.com/nextcloud/files_downloadactivity/master/docs/screenshot.png</screenshot> | |||
|
|
|||
| <dependencies> | |||
| <nextcloud min-version="24" max-version="26" /> | |||
| <nextcloud min-version="26" max-version="28" /> | |||
There was a problem hiding this comment.
Should add 29 then as well?
nickvergessen
approved these changes
May 16, 2024
Closed
|
@nickvergessen Any chance this could be merged? This is spamming my logs. |
|
If anyone is interested in taking over maintainership we can do so. |
skjnldsv
reviewed
Jul 31, 2024
skjnldsv
force-pushed
the
159-upgrade-to-nextcloud-28
branch
from
7325505 to
b0a5f43
Compare
skjnldsv
approved these changes
Jul 31, 2024
skjnldsv
force-pushed
the
159-upgrade-to-nextcloud-28
branch
from
b0a5f43 to
c5c70d7
Compare
Signed-off-by: Christian Baumann <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv
force-pushed
the
159-upgrade-to-nextcloud-28
branch
from
c5c70d7 to
6a37015
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade of the app to the new event API to make it work with Nextcloud 28.
https://help.nextcloud.com/t/symfony-event-dispatcher-update-in-nextcloud-server-28-breaking-changes/167550