Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove link to file #306

Merged
merged 1 commit into from
Jan 16, 2024
Merged

remove link to file #306

merged 1 commit into from
Jan 16, 2024

Conversation

ArtificialOwl
Copy link
Member

Replace 'file' type to 'highlight' to remove link to infected file.

  • If the file was deleted, the link was already broken
  • If the file was not deleted, the link would have download the file.

@ArtificialOwl ArtificialOwl force-pushed the fix/h670/no-link-to-infected-file branch from ea2a3b2 to b1a89f6 Compare January 8, 2024 12:28
@ArtificialOwl
Copy link
Member Author

image

come-nc
come-nc approved these changes Jan 9, 2024
View reviewed changes
lib/Activity/Provider.php
$parameters['file'] = [
'type' => 'highlight',
'id' => $event->getObjectName(),
'name' => $event->getObjectName(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also changed from name to full path by not calling basename, not sure if intended (but given it’s not a link, full path is useful)

@ArtificialOwl
Copy link
Member Author

@come-nc @skjnldsv can I also have a review on #307 that should fix the Lint php-cs error we are facing here !

@ArtificialOwl ArtificialOwl mentioned this pull request Jan 10, 2024
Merged
@ArtificialOwl @skjnldsv
remove link to file
a9bc6e1 
Signed-off-by: Maxence Lange <[email protected]>
@skjnldsv skjnldsv force-pushed the fix/h670/no-link-to-infected-file branch from b1a89f6 to a9bc6e1 Compare January 11, 2024 08:32
@ArtificialOwl ArtificialOwl merged commit 7a21de1 into master Jan 16, 2024
48 checks passed
@ArtificialOwl ArtificialOwl deleted the fix/h670/no-link-to-infected-file branch January 16, 2024 10:03
This was referenced Jan 16, 2024
Merged
Merged
@sol8712
Copy link

sol8712 commented Jan 18, 2024

Thanks for the fix! You all are awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
4. to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArtificialOwl @sol8712 @skjnldsv @come-nc