Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: explictly add sphinx_rtd_theme to extensions to fix search #9935

Merged
merged 1 commit into from
Mar 22, 2023
Merged

fix: explictly add sphinx_rtd_theme to extensions to fix search #9935

merged 1 commit into from
Mar 22, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Mar 22, 2023

@st3iny st3iny self-assigned this Mar 22, 2023
st3iny
st3iny commented Mar 22, 2023
View reviewed changes
Copy link
Member Author

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally and the search works again. Note that sphinx v6 has to be manually installed to be able to reproduce the issue.

pip install sphinx==6

@nickvergessen nickvergessen merged commit 8a948f5 into master Mar 22, 2023
@nickvergessen nickvergessen deleted the fix/9905/search branch March 22, 2023 06:54
@nickvergessen
Copy link
Member

And backport to stable24 I guess?

@st3iny
Copy link
Member Author

st3iny commented Mar 22, 2023

/backport to stable24

@st3iny
Copy link
Member Author

st3iny commented Mar 22, 2023

/backport to stable25

@st3iny
Copy link
Member Author

st3iny commented Mar 22, 2023

/backport to stable26

This was referenced Mar 22, 2023
Merged
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 22, 2023
Merged
@nickvergessen
Copy link
Member

23 seems also broken:
https://docs.nextcloud.com/server/23/user_manual/en/search.html

Can we backport all the thigns there too?

@st3iny st3iny mentioned this pull request Mar 22, 2023
Merged
@st3iny
Copy link
Member Author

st3iny commented Mar 22, 2023

23 seems also broken: https://docs.nextcloud.com/server/23/user_manual/en/search.html

Can we backport all the thigns there too?

Done (#9942)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@st3iny st3iny

Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search doesn't work due to missing jQuery
3 participants
@st3iny @nickvergessen @ChristophWurst