Give some pointers for the PHP8.1 support for apps #8165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
st3iny,
mejo-,
miaulalala,
julien-nc and
come-nc
come-nc
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
Maybe provide a link to PHP 8.1 changes?
https://www.php.net/migration81 or https://stitcher.io/blog/new-in-php-81#breaking-changes
Comment on lines
24
to
25
| tbd | ||
|
|
There was a problem hiding this comment.
those are for the front-end section, I'd leave that for now
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
enhancement/dev-app-upgrade-php81
branch
from
7fbf77a to
eaeeb94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are quite generic but matches what we did for the groupware apps. So this should be helpful for others as well.
Ref nextcloud/groupware#27