Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AI/ContextChat): update docs #12529

Merged
merged 5 commits into from
Jan 23, 2025
Merged

fix(AI/ContextChat): update docs #12529

merged 5 commits into from
Jan 23, 2025

Conversation

kyteinsky
Copy link
Contributor

🖼️ Screenshots

@kyteinsky kyteinsky requested review from marcelklehr and julien-nc and removed request for marcelklehr January 22, 2025 10:30
julien-nc
julien-nc previously requested changes Jan 22, 2025
View reviewed changes
admin_manual/ai/app_context_chat.rst Outdated Show resolved Hide resolved
admin_manual/ai/app_context_chat.rst Outdated Show resolved Hide resolved
admin_manual/ai/app_context_chat.rst Outdated Show resolved Hide resolved
kyteinsky and others added 3 commits January 22, 2025 16:10
@kyteinsky @julien-nc
Update admin_manual/ai/app_context_chat.rst
1a5a772 
Co-authored-by: Julien Veyssier <[email protected]>
Signed-off-by: Anupam Kumar <[email protected]>
@kyteinsky @julien-nc
Update admin_manual/ai/app_context_chat.rst
624375f 
Co-authored-by: Julien Veyssier <[email protected]>
Signed-off-by: Anupam Kumar <[email protected]>
@kyteinsky @julien-nc
Update admin_manual/ai/app_context_chat.rst
4ac4dad 
Co-authored-by: Julien Veyssier <[email protected]>
Signed-off-by: Anupam Kumar <[email protected]>
@kyteinsky
Copy link
Contributor Author

what to do about the spell check failing elsewhere?

@marcelklehr
Copy link
Member

You can fix the spellcheck in this pr

@kyteinsky
fix spell check
ae4a3c6 
Signed-off-by: Anupam Kumar <[email protected]>
@kyteinsky
Copy link
Contributor Author

Seems like the workflow changed, they were pretty old changes.

@marcelklehr marcelklehr merged commit ded5304 into master Jan 23, 2025
12 checks passed
@marcelklehr marcelklehr deleted the fix/update-cc branch January 23, 2025 08:50
@kyteinsky
Copy link
Contributor Author

/backport to stable31

@kyteinsky
Copy link
Contributor Author

/backport to stable30

@backportbot backportbot bot mentioned this pull request Jan 23, 2025
Open
@backportbot backportbot bot mentioned this pull request Jan 23, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@julien-nc julien-nc julien-nc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyteinsky @marcelklehr @julien-nc