Changed the php version back to 5.6 for Nextcloud 9 and 10 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyphar
reviewed
Mar 7, 2017
update.sh
Outdated
| @@ -16,7 +16,11 @@ for latest in "${latests[@]}"; do | |||
| for variant in apache fpm; do | |||
| # Create the version+variant directory with a Dockerfile. | |||
| mkdir -p "$version/$variant" | |||
| cp Dockerfile.template "$version/$variant/Dockerfile" | |||
| if [ "$version" == "11.0" ]; then | |||
There was a problem hiding this comment.
This is not really a future-compatible change. I would recommend defining a function like this:
# version_gte A B returns whether A >= B
function version_gte() {
[[ "$(printf '%s\n' "$@" | sort -V | head -n1)" != "$1" || "$1" == "$2" ]];
}Which you could then use like this:
template="Dockerfile.template"
if version_gte "$version" "11.0"; then
template="Dockerfile-php7.template"
fi
cp "$template" "$version/$variant/Dockerfile"
|
Thanks a lot @tilosp for this, this is amazing, I'll merge it right away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40