-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alpine variant #259
Add Alpine variant #259
Conversation
Only 64-bit works so far. @tianon do you know how I can build APCu on 32-bit? |
Dockerfile-alpine.template
Outdated
bash \ | ||
coreutils \ | ||
rsync | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should merge the top 3 RUN commands into a single one to keep it a similar as possible to the debian one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way is better for build caching. See also other images in the docker-library.
I can adjust the Debian images if required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also update |
Adding |
(https://ram.tianon.xyz/post/2017/12/26/dockerize-compiled-software.html is a writeup about how I usually solve this type of issue generally when Dockerizing software) |
trigger Travis again |
Travis is not building for some reason. @tianon thanks for the hint. But I'm still confused why this is working on
I think this is not related to this PR. I'd like to add only Alpine images here. |
Travis is done now. Only fetching from keyserver failed once, which is acceptable. |
It is related to this pr. If we merge this now the Jenkins server will try to build the alpine variant on arm32v5 and arm32v7 which will fail because there is no base image. |
Okay, I can do this. But the bashbrew dependency makes it a bit tricky. I didn't found a proper way to add bashbrew to Travis, but I don't want to hardcode the architectures again. |
FWIW, up-to-date pre-built binaries of |
@tilosp can you help me out with the bashbrew dependency on Travis? |
@tilosp thanks for fixing it. I would like to request a review again. |
@J0WI i added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tianon please review |
Thanks a lot for your work! |
This adds a php-fpm-alpine variant with the same dependencies installed as the Debian variants, but without Cron (#253). The
entrypoint.sh
is not fully POSIX compatible, so there are some extra dependencies for it.