Improve handling of secret variables and files in autoconfig #2141
Conversation
In the recent state, the autoconfig feature required either all database secrets to be passed as environment variables, or all to be passed as secret files, but didn't allow to use a mix of these variants, e.g. passing the database user and name as environment variables, and only the password as a file. This is now fixed and allows working with database values the same way, as the Postgres and MySQL/MariaDB images do; with mixed variants also. Signed-off-by: Patrick Hobusch <[email protected]>
joshtrichards
added
enhancement
3. to review
feature: auto config (environment variables)
|
@J0WI 👀 |
|
Hello @J0WI @joshtrichards how can I help to move this forward? |
|
@J0WI I think the logic of my PR is a bit better, because it also checks the existence of the files. But tbh there seems something wrong with Nextcloud. In my deployment I manually needed to set the It would be nice to move the PR forward, please let me know how I can help... |
|
Unfortunately, the way this PR was (not) handled led me to the conclusion that this image is not suitable for production. Since the AIO image violates basic Docker principles, I will replace my Docker-based pilot setup with the service from NixOS. |
Where precisely are you seeing references to (or a dependency on) this variable ( For what it's worth, I just brought up a from scratch test stack with the Apache v28 image with PostgreSQL and had no problems. |
In the recent state, the autoconfig feature required either all database secrets to be passed as environment variables, or all to be passed as secret files, but didn't allow to use a mix of these variants, e.g. passing the database user and name as environment variables, and only the password as a file.
This is now fixed and allows working with database values the same way, as the Postgres and MySQL/MariaDB images do; with mixed variants also.