Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(README) Persistent volume upgrade.exclude clarification #2133

Merged
merged 2 commits into from
Jan 12, 2024
Merged

enh(README) Persistent volume upgrade.exclude clarification #2133

merged 2 commits into from
Jan 12, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Dec 28, 2023 •
edited
Loading

  • Make it a called out warning
  • Clarify the language
  • Clarity trade-offs
  • Adds a couple headings in that section to allow for direct linking (as a FAQ/etc)

Fixes: #2132

image

@joshtrichards
enh(README) Persistent volume upgrade.exclude clarification
fd6f811 
- Make the warning more prominent
- Clarify the language
- Clarity trade-offs

Fixes: #2132  

Signed-off-by: Josh Richards <[email protected]>
@joshtrichards joshtrichards requested a review from J0WI December 28, 2023 15:12
@joshtrichards joshtrichards mentioned this pull request Dec 28, 2023
Closed
@MarcS1975
Copy link

I would make it even more explicit. People need to understand the severity of a potential mistake here.

WARNING: DO NOT MOUNT ANY USER DATA TO /var/www/html. YOU WILL LOOSE ALL YOUR DATA WHEN UPGRADING THE NEXTCLOUD DOCKER IMAGE.
Unless you are OK to loose all your mounted data during NC upgrades, we recommend mounting only to /var/www/html/data or /var/www/html/config and below since those folders will be excluded from deletion during upgrades. Further exclusions (in addition to /data/ and /config/) are defined in upgrade.exclude but require a custom image build.

J0WI
J0WI reviewed Jan 9, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@joshtrichards @J0WI
Update README.md
accf5bf 
Co-authored-by: J0WI <[email protected]>
Signed-off-by: Josh <[email protected]>
@joshtrichards joshtrichards merged commit ea64bed into master Jan 12, 2024
15 of 20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the enh/readme/persist-volumes-custom-upgrade-exclude branch January 12, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J0WI J0WI J0WI left review comments

Assignees
No one assigned
Labels
3. to review docs enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NC upgrade erased entire data folder content
3 participants
@joshtrichards @MarcS1975 @J0WI