Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for PR #2095 breaking post-installation scripts in k8s #2115

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Fix for PR #2095 breaking post-installation scripts in k8s #2115

merged 4 commits into from
Jan 9, 2024
+1 −1

Conversation

Sad-Soul-Eater
Copy link
Contributor

@Sad-Soul-Eater Sad-Soul-Eater commented Dec 5, 2023 •
edited by joshtrichards
Loading

Fixes #2114

@Sad-Soul-Eater
Fix docker-entrypoint.sh
c29024e 
Signed-off-by: Yevhen Kolomeiko <[email protected]>
joshtrichards
joshtrichards approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to test, but simple change that makes sense and syntax is valid.

@joshtrichards
Copy link
Member

@dvaerum Feel like weighing in?

@joshtrichards joshtrichards changed the title Fix for issue #2114 Fix for PR #2095 breaking post-installation scripts in k8s Dec 5, 2023
@dvaerum
Copy link
Contributor

dvaerum commented Dec 7, 2023

@dvaerum Feel like weighing in?

Yes, merge 😉 From what I have done of quick testing, it works.

But, I am curious because I cannot see how this problem should be k8s released 🤔

@Sad-Soul-Eater
Copy link
Contributor Author

But, I am curious because I cannot see how this problem should be k8s released 🤔

In k8s ConfigMaps and Secrets mounts to dir as symlinks to ..data dir, this is non documented expected behaviour

@dvaerum
Copy link
Contributor

dvaerum commented Dec 9, 2023

Thanks for the info @Sad-Soul-Eater that is good to know

J0WI
J0WI requested changes Dec 12, 2023
View reviewed changes
docker-entrypoint.sh Outdated Show resolved Hide resolved
@Sad-Soul-Eater
Fix docker-entrypoint.sh for alpine
ab7267f 
Signed-off-by: Yevhen Kolomeiko <[email protected]>
@Sad-Soul-Eater Sad-Soul-Eater requested a review from J0WI December 12, 2023 22:33
@jessebot jessebot mentioned this pull request Dec 15, 2023
Closed
@jessebot
Copy link
Contributor

just closed #2125 as this would resolve some issues we're having in the nextcloud/helm repo. Thank you @Sad-Soul-Eater !

@J0WI can this be merged now?

This was referenced Dec 15, 2023
Open
Open
J0WI
J0WI reviewed Dec 20, 2023
View reviewed changes
docker-entrypoint.sh Outdated Show resolved Hide resolved
@Sad-Soul-Eater Sad-Soul-Eater requested a review from J0WI December 21, 2023 01:08
@Sad-Soul-Eater Sad-Soul-Eater mentioned this pull request Dec 22, 2023
Closed
@PhrozenByte PhrozenByte mentioned this pull request Dec 23, 2023
Open
@J0WI J0WI merged commit d89def2 into nextcloud:master Jan 9, 2024
16 of 21 checks passed
@Sad-Soul-Eater Sad-Soul-Eater deleted the Sad-Soul-Eater-patch-1 branch January 9, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvaerum dvaerum dvaerum left review comments

@J0WI J0WI J0WI approved these changes

@joshtrichards joshtrichards joshtrichards approved these changes

Assignees
No one assigned
Labels
3. to review bug feature: auto config (hooks)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PR #2095 broke post-installation scripts in k8s
5 participants
@Sad-Soul-Eater @joshtrichards @dvaerum @jessebot @J0WI