Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Apache LimitRequestBody with env variable APACHE_BODY_LIMIT #2065

Merged
merged 5 commits into from
Sep 16, 2023

Conversation

adripo
Copy link
Contributor

@adripo adripo commented Sep 13, 2023

This PR will solve #1796 and allows to customize LimitRequestBody with env variable APACHE_BODY_LIMIT.
Documented in README.md

Also fixed apache extras missing single quotes.

Context:

  • Apache's default for LimitRequestBody changed from 0 (unlimited) to 1 GiB in v2.4.53 which was released on June 08, 2022. This is becoming a more widely deployed version (e.g. Debian 12 currently ships with v2.4.57 and Ubuntu kinentic/22.10 ships with v2.4.54)
  • See https://httpd.apache.org/docs/current/en/mod/core.html#limitrequestbody where this change in behavior is documented
  • Impacts non-chunking client transactions (effectively restricting them to <1GB)

Related docs:
nextcloud/documentation#10989

Dockerfile-debian.template Outdated Show resolved Hide resolved
@J0WI J0WI mentioned this pull request Sep 14, 2023
update.sh Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@adripo adripo requested a review from J0WI September 15, 2023 11:52
Signed-off-by: adripo <[email protected]>
@J0WI J0WI merged commit 90064ed into nextcloud:master Sep 16, 2023
15 of 21 checks passed
ananace pushed a commit to ananace/docker-nextcloud that referenced this pull request May 10, 2024
…cloud#2065)

* feat: set apache LimitRequestBody

Signed-off-by: adripo <[email protected]>

* feat: APACHE_BODY_LIMIT variable

Signed-off-by: adripo <[email protected]>

* fix: move ENV to existing VARIANT_EXTRAS

Signed-off-by: adripo <[email protected]>

* docs: updated var description

Signed-off-by: adripo <[email protected]>

* fix: remove comment

Signed-off-by: adripo <[email protected]>

---------

Signed-off-by: adripo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants