Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine Linux image with fpm and php7.0 #17

Closed
wants to merge 19 commits into from
Closed

Alpine Linux image with fpm and php7.0 #17

wants to merge 19 commits into from

Conversation

eniac111
Copy link

@eniac111 eniac111 commented Oct 15, 2016

Hello,

I've divided the images in different directories and inserted the Travis tests from the official Docker images, they are passing.
The only difference between the images is that there is still no Memcache support in php-fpm 7.0.

https://travis-ci.org/eniac111/nextcloud-docker/branches

@pierreozoux
Copy link
Member

Wow, thanks for the amazing work!

As already said, I'm waiting docker-library/official-images#2185 to be merged, and then, I'll add your PR :)

@SnowMB
Copy link
Contributor

SnowMB commented Oct 15, 2016

Awesome work! 👍

@pierreozoux
Copy link
Member

pierreozoux commented Jan 6, 2017

Ok, we got merged \o/ the image is now official!

@eniac111 various remarks before merging this one :)
Could you put your PR on top of #21 please?
And one PR for travis and one for Alpine would be amazing (or just 2 commits in this PR would be fine also).

Thanks again!

@eniac111
Copy link
Author

eniac111 commented Jan 6, 2017

Hello @pierreozoux and congrats :)
I moved my Alpine images to separate version directories like in #21 but the official NextCloud image is still in "php5.6" directory. I'm not sure what to do with it. It may cause a conflict? Should I move it to "10.0/fpm"?

About Travis, I may move it to another branch and create a separate pull request for it?

@pierreozoux
Copy link
Member

Sorry for the delay, I just merge the PR to reorganize by folder.
If you can rebase and PR on top, would be fine.
Let's use the "alpine" dir and tag.

@pierreozoux
Copy link
Member

Arf, and also, can you answer there also?
#10

We need to be coherent, so either all php7 or not if you see what I mean.

@eniac111
Copy link
Author

Hello @pierreozoux,

I'm not sure how to deal with the conflicts. It would be easier if I create a new, fresh clone of the repository, commit the latest changes and create PRs for the Alpine image and Travis?

@pierreozoux
Copy link
Member

Yes please do so :)

And the best would be to also use update.sh!

Let me know if you need help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants