Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy over config file to new location on windows #768

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Nov 1, 2018

Fixes #766

I didn't test yet as my windows VM does funny things. So a quick run appreciated @camilasan

@rullzer rullzer added this to the 2.5 milestone Nov 1, 2018
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense. 👍

@jpnurmi
Copy link
Member

jpnurmi commented Nov 2, 2018

👍 looks good

The old config path with some additional entries for testing:

C:\>tree /F C:\Users\jpnurmi\AppData\Local\Nextcloud
Folder PATH listing for volume OS
Volume serial number is 000055F7 EC39:3404
C:\USERS\JPNURMI\APPDATA\LOCAL\NEXTCLOUD
│   cookies0.db
│   nextcloud.cfg
│
├───empty
└───subdir
    ├───subdir1
    │       file1.txt
    │
    └───subdir2
            file2.txt

Nuke the new config path:

C:\>rd /S /Q C:\Users\jpnurmi\AppData\Roaming\Nextcloud

C:\>tree /F C:\Users\jpnurmi\AppData\Roaming\Nextcloud
Folder PATH listing for volume OS
Volume serial number is 0000DD15 EC39:3404
C:\USERS\JPNURMI\APPDATA\ROAMING\NEXTCLOUD
Invalid path - \USERS\JPNURMI\APPDATA\ROAMING\NEXTCLOUD
No subfolders exist

After launching the client:

C:\>tree /F C:\Users\jpnurmi\AppData\Roaming\Nextcloud
Folder PATH listing for volume OS
Volume serial number is 0000B5E0 EC39:3404
C:\USERS\JPNURMI\APPDATA\ROAMING\NEXTCLOUD
│   cookies0.db
│   nextcloud.cfg
│
├───empty
└───subdir
    ├───subdir1
    │       file1.txt
    │
    └───subdir2
            file2.txt

@jpnurmi jpnurmi self-requested a review November 2, 2018 19:22
@rullzer
Copy link
Member Author

rullzer commented Nov 2, 2018

Thanks for testing @jpnurmi

@rullzer rullzer merged commit af8a281 into master Nov 2, 2018
@rullzer rullzer deleted the fix/766/copy_over_old_windows_config branch November 2, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants